[webkit-reviews] review denied: [Bug 40598] [Qt] QtWebkit Crashes on loading CelticKane Standard tests : [Attachment 58728] Move big allocation from stack to heap.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 6 10:08:38 PDT 2010


Geoffrey Garen <ggaren at apple.com> has denied Viatcheslav Ostapenko
<ostapenko.viatcheslav at nokia.com>'s request for review:
Bug 40598: [Qt] QtWebkit Crashes on loading CelticKane Standard tests
https://bugs.webkit.org/show_bug.cgi?id=40598

Attachment 58728: Move big allocation from stack to heap.
https://bugs.webkit.org/attachment.cgi?id=58728&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Even if this is the right approach (and, without any SunSpider numbers, I'm not
convinced that it is), I don't think the inline capacity should go all the way
to 0. How about 16?

How much stack does S60 have?

If S60's stack space is truly pathologically small, maybe the best solution is
just to conditionally disable all Vector inline capacity on S60. Should be
pretty easy to make that change in wtf/Vector.h.


More information about the webkit-reviews mailing list