[webkit-reviews] review granted: [Bug 41348] Remove global variables from XSLTProcessorLibxslt.cpp : [Attachment 60634] New proposed patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Andreas Wictor
<andreas.wictor at xcerion.com>'s request for review:
Bug 41348: Remove global variables from XSLTProcessorLibxslt.cpp
https://bugs.webkit.org/show_bug.cgi?id=41348

Attachment 60634: New proposed patch
https://bugs.webkit.org/attachment.cgi?id=60634&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +    // m_sourceNode is set (and reset) in the transformToString function
> +    // so that the libxslt loader callback can access the source node
> +    // of the transformation
> +    Node* m_sourceNode;

This seems too wordy (of course m_sourceNode is the source node), and doesn't
directly explain why this needn't be a RefPtr. I suggest something like "Source
node is only non-null in transformToString(), so this cannot become a dangling
pointer".

> +    // Save a pointer to the stylesheet so that we can access it from the
libxslt loader callback

Comments are full sentences, and should end with a period.

r=me