[webkit-reviews] review granted: [Bug 41653] Add new WebKitTestRunner project for Windows : [Attachment 60590] patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Alice Liu <alice.liu at apple.com>'s
request for review:
Bug 41653: Add new WebKitTestRunner project for Windows
https://bugs.webkit.org/show_bug.cgi?id=41653

Attachment 60590: patch
https://bugs.webkit.org/attachment.cgi?id=60590&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>

>	   Reviewed by Eric Seidel.
> Index: WebKitTools/WebKitTestRunner/WebKitTestRunnerPrefix.h
> ===================================================================
> --- WebKitTools/WebKitTestRunner/WebKitTestRunnerPrefix.h	(revision
62511)
> +++ WebKitTools/WebKitTestRunner/WebKitTestRunnerPrefix.h	(working copy)
> @@ -27,4 +27,9 @@
>  #include <Cocoa/Cocoa.h>
>  #endif
>  
> +// If we don't define these, they get defined in windef.h. 
> +// We want to use std::min and std::max
> +#define max max
> +#define min min

I think these probably want to be behind a #if PLATFORM(WIN) or some such.

Otherwise, r=me.