[webkit-reviews] review requested: [Bug 40797] [Qt] Decode images directly to QPixmap : [Attachment 60606] Update to take advantage of new APIs in Qt + null pixmap

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin.poulain at nokia.com> has asked  for review:
Bug 40797: [Qt] Decode images directly to QPixmap
https://bugs.webkit.org/show_bug.cgi?id=40797

Attachment 60606: Update to take advantage of new APIs in Qt + null pixmap
https://bugs.webkit.org/attachment.cgi?id=60606&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
> (From update of attachment 60555 [details])
> WebCore/platform/graphics/qt/ImageDecoderQt.cpp:200
>  +	      pixmap = QPixmap::fromImage(img);
> I believe this function can return a null pixmap if we run out of memory
(I've seen this actually on Symbian).

Yep you are right, the pixmap could be null after this call.
I updated the patch to simply abort as soon as we get a null pixmap.