[webkit-reviews] review denied: [Bug 40558] [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT : [Attachment 60602] patch - snapshot of current state (added tkent's fix, NOBODY-fied the reviewer in the ChangeLogs)

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 40558: [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=40558

Attachment 60602: patch - snapshot of current state (added tkent's fix,
NOBODY-fied the reviewer in the ChangeLogs)
https://bugs.webkit.org/attachment.cgi?id=60602&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>


> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> index 62ad190..fa7d242 100644
> --- a/WebKitTools/ChangeLog
> +++ b/WebKitTools/ChangeLog
> @@ -1,3 +1,72 @@
> +2010-07-05  Roland Steiner  <rolandsteiner at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium
DRT
> +	   https://bugs.webkit.org/show_bug.cgi?id=40558
> +
> +	   Upstream DevTools for Chromium DRT.
> +	   (original Chromium files rev. 51287)
> +
> +	   * DumpRenderTree/DumpRenderTree.gypi:
> +	   * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added.
> +	   (DRTDevToolsAgent::DRTDevToolsAgent):
> +	   (DRTDevToolsAgent::setWebView):
> +	   (DRTDevToolsAgent::sendMessageToFrontend):
> +	   (DRTDevToolsAgent::forceRepaint):
> +	   (DRTDevToolsAgent::runtimeFeatureStateChanged):
> +	   (DRTDevToolsAgent::injectedScriptSource):
> +	   (DRTDevToolsAgent::injectedScriptDispatcherSource):
> +	   (DRTDevToolsAgent::debuggerScriptSource):
> +	   (DRTDevToolsAgent::asyncCall):
> +	   (DRTDevToolsAgent::call):
> +	   (DRTDevToolsAgent::webDevToolsAgent):
> +	   (DRTDevToolsAgent::attach):
> +	   (DRTDevToolsAgent::detach):
> +	   (DRTDevToolsAgent::setTimelineProfilingEnabled):
> +	   (DRTDevToolsAgent::evaluateInWebInspector):
> +	   (DRTDevToolsAgent::dispatchMessageLoop):
> +	   * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added.
> +	   (DRTDevToolsAgent::~DRTDevToolsAgent):
> +	   (DRTDevToolsAgent::hostIdentifier):
> +	   * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
> +	   * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
> +	   (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
> +	   (DRTDevToolsCallArgs::~DRTDevToolsCallArgs):
> +	   (DRTDevToolsCallArgs::callsCount):
> +	   * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added.
> +	   (DRTDevToolsClient::DRTDevToolsClient):
> +	   (DRTDevToolsClient::~DRTDevToolsClient):
> +	   (DRTDevToolsClient::sendMessageToAgent):
> +	   (DRTDevToolsClient::sendDebuggerCommandToAgent):
> +	   (DRTDevToolsClient::activateWindow):
> +	   (DRTDevToolsClient::closeWindow):
> +	   (DRTDevToolsClient::dockWindow):
> +	   (DRTDevToolsClient::undockWindow):
> +	   (DRTDevToolsClient::asyncCall):
> +	   (DRTDevToolsClient::call):
> +	   (DRTDevToolsClient::allMessagesProcessed):
> +	   * DumpRenderTree/chromium/DRTDevToolsClient.h:
> +	   * DumpRenderTree/chromium/EventSender.cpp:
> +	   * DumpRenderTree/chromium/LayoutTestController.cpp:
> +	   (LayoutTestController::LayoutTestController):
> +	   (LayoutTestController::closeWebInspector):
> +	   (LayoutTestController::setTimelineProfilingEnabled):
> +	   (LayoutTestController::evaluateInWebInspector):
> +	   * DumpRenderTree/chromium/LayoutTestController.h:
> +	   * DumpRenderTree/chromium/TestShell.cpp:
> +	   (TestShell::TestShell):
> +	   (TestShell::~TestShell):
> +	   (TestShell::createDRTDevToolsClient):
> +	   (TestShell::showDevTools):
> +	   (TestShell::closeDevTools):
> +	   (TestShell::runFileTest):
> +	   (TestShell::createNewWindow):
> +	   * DumpRenderTree/chromium/TestShell.h:
> +	   (TestShell::drtDevToolsAgent):
> +	   (TestShell::drtDevToolsClient):
> +	   * DumpRenderTree/chromium/config.h:
> +
>  2010-07-05  Csaba Osztrogonác  <ossy at webkit.org>
>  
>	   Reviewed by Eric Seidel.
> @@ -40,7 +109,6 @@
>  
>	   * Scripts/webkitpy/common/checkout/scm.py:
>	   * Scripts/webkitpy/common/checkout/scm_unittest.py:
> -
>  2010-07-03  Patrick Gansterer  <paroga at paroga.com>

Do not change unrelated part of ChangeLog.


WebKit/chromium/WebKit.gyp:633
 +			    '<(SHARED_INTERMEDIATE_DIR)/webkit', # for a header
generated by grit
Is this needed?