[webkit-reviews] review granted: [Bug 41660] Implement InCaptionMode : [Attachment 60598] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 6 00:28:26 PDT 2010


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 41660: Implement InCaptionMode
https://bugs.webkit.org/show_bug.cgi?id=41660

Attachment 60598: Patch
https://bugs.webkit.org/attachment.cgi?id=60598&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Hot dawg!  You found my adoption agency bug!  I knew I was just one damn typo
away from fixing a zillion tests.  Thank you!

It's slightly confusing to both fix the AA bug and add InCaption mode at once.

if (token.name() == bodyTag || token.name() == colTag || token.name() ==
colgroupTag || token.name() == htmlTag || token.name() == tbodyTag ||
token.name() == tdTag || token.name() == tfootTag || token.name() == thTag ||
token.name() == theadTag || token.name() == trTag) {
really really really needs a helper function sooner than later.


More information about the webkit-reviews mailing list