[webkit-reviews] review granted: [Bug 41623] Implement basic text node coalescing : [Attachment 60551] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 41623: Implement basic text node coalescing
https://bugs.webkit.org/show_bug.cgi?id=41623

Attachment 60551: Patch
https://bugs.webkit.org/attachment.cgi?id=60551&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/dom/CharacterData.cpp:62
 +  PassRefPtr<StringImpl> CharacterData::parserAppendData(const String& arg)
We need a bunch more of these parser* functions.

WebCore/dom/CharacterData.h:45
 +	// Similar to appendData, but optimized for the parser (e.g., no
mutation
I would have used "Like appendData" to keep it to one 80c line. :)

WebCore/html/HTMLTreeBuilder.cpp:1583
 +		// was the last text node inserted by the parser.
Can we write a test which fails this so we know when we fix it?  Or do we know
it's already covered?