[webkit-reviews] review granted: [Bug 41627] Implement InSelectMode : [Attachment 60577] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 5 20:58:46 PDT 2010
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 41627: Implement InSelectMode
https://bugs.webkit.org/show_bug.cgi?id=41627
Attachment 60577: Patch
https://bugs.webkit.org/attachment.cgi?id=60577&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/html/HTMLTreeBuilder.cpp:913
+ insertElement(token);
Why no return after this? We need to figure out what the right pattern here
is.
WebCore/html/HTMLTreeBuilder.cpp:924
+ insertElement(token);
Here again? No return?
Looks OK, I think.
More information about the webkit-reviews
mailing list