[webkit-reviews] review granted: [Bug 41584] [Qt] Add DRT support for pageProperty etc. : [Attachment 60478] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 5 14:42:04 PDT 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 41584: [Qt] Add DRT support for pageProperty etc.
https://bugs.webkit.org/show_bug.cgi?id=41584
Attachment 60478: Patch
https://bugs.webkit.org/attachment.cgi?id=60478&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
8 QString DumpRenderTreeSupportQt::pageSizeAndMarginsInPixels(QWebFrame* frame,
int pageIndex,
679 int width, int height,
680 int marginTop,
681 int marginRight,
682 int marginBottom,
683 int marginLeft)
This is wrong coding style, put it on one line. Apart from that r=me.
More information about the webkit-reviews
mailing list