[webkit-reviews] review denied: [Bug 40558] [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT : [Attachment 60497] patch - snapshot of current state (removed unnecessary struct)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 5 03:35:35 PDT 2010
Kent Tamura <tkent at chromium.org> has denied review:
Bug 40558: [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=40558
Attachment 60497: patch - snapshot of current state (removed unnecessary
struct)
https://bugs.webkit.org/attachment.cgi?id=60497&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
I don't know why CQ rejects the patch :-<
WebKitTools/DumpRenderTree/chromium/TestShell.cpp:125
+ m_drtDevToolsClient.set(new DRTDevToolsClient(agent, webView()));
webView() should be m_devTools->webView().
This is the root cause of no frontendLoaded() called.
More information about the webkit-reviews
mailing list