[webkit-reviews] review granted: [Bug 40768] Web Inspector: WebSocket in Resources tab : [Attachment 60503] Patch v2 (Updated as per Pavel's comments)

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 40768: Web Inspector: WebSocket in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=40768

Attachment 60503: Patch v2 (Updated as per Pavel's comments)
https://bugs.webkit.org/attachment.cgi?id=60503&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Looks good. One thing before we land it: I still don't like the way it forks
InspectorResource. What you were suggesting (extracting the common part into a
superclass) sounds like a good solution to me. We could do it later, but it
just might be easier to do it now, before the HTTP and WebSocket concepts are
mixed in the InspectorResource class. I also foresee InspectorWebSocketResource
getting more functionality InspectorResource does not have (like having chunks
of data available). The complex thing is that this hierarchy needs to exist
both in naive and js layers. Would you sign up for such a refactoring?

WebCore/inspector/InspectorResource.h:110
 +	    KURL documentURL() const { return m_documentURL; }
Does not seem to be used.