[webkit-reviews] review granted: [Bug 40558] [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT : [Attachment 60495] patch - snapshot of current state (fixed style bugs and addressed review remarks)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jul 4 23:25:33 PDT 2010
Kent Tamura <tkent at chromium.org> has granted Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 40558: [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=40558
Attachment 60495: patch - snapshot of current state (fixed style bugs and
addressed review remarks)
https://bugs.webkit.org/attachment.cgi?id=60495&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
WebKitTools/DumpRenderTree/chromium/TestShell.h:88
+ TestShell* m_testShell;
We don't prepend "m_" to public data members.
More information about the webkit-reviews
mailing list