[webkit-reviews] review granted: [Bug 41587] Add basic "in table body" mode to support <tr> insertion : [Attachment 60488] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jul 4 21:28:12 PDT 2010
Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 41587: Add basic "in table body" mode to support <tr> insertion
https://bugs.webkit.org/show_bug.cgi?id=41587
Attachment 60488: Patch
https://bugs.webkit.org/attachment.cgi?id=60488&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/html/HTMLTreeBuilder.cpp:787
+ m_openElements.popUntilTableBodyScopeMarker(); // How is there
ever anything to pop?
We could add an assert that this is a nop if we want to learn.
WebCore/html/HTMLTreeBuilder.cpp:805
+ notImplemented(); // process using "in table" rules
Our strategy here has been to move that code into a separate function that we
can call.
More information about the webkit-reviews
mailing list