[webkit-reviews] review denied: [Bug 40558] [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT : [Attachment 60363] patch - snapshot of current state (removed debugging code, fixed modes)

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 40558: [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=40558

Attachment 60363: patch - snapshot of current state (removed debugging code,
fixed modes)
https://bugs.webkit.org/attachment.cgi?id=60363&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
Anyway, please fix style errors.


WebKitTools/DumpRenderTree/chromium/DRTDevToolsClient.cpp:45
 +  using WebKit::WebDevToolsAgent;
We prefer "using namespace WebKit;" in .cpp files.



WebKitTools/DumpRenderTree/chromium/DRTDevToolsClient.cpp:112
 +  void DRTDevToolsClient::call(const DRTDevToolsCallArgs &args)
"DRTDevToolsCallArgs &arg" -> "DRTDevToolsCallArgs& arg"


WebKitTools/DumpRenderTree/chromium/TestShell.cpp:124
 +  void TestShell::createDRTDevToolsClient(DRTDevToolsAgent *agent)
"DRTDevToolsAgent *agent" -> "DRTDevToolsAgent* agent"


WebKitTools/DumpRenderTree/chromium/config.h:44
 +  #define NOTREACHED() DCHECK(false)
Do we still need this?


WebKitTools/DumpRenderTree/chromium/EventSender.cpp:61
 +  #endif // OS(WINDOWS)
This patch doesn't need this change.