[webkit-reviews] review granted: [Bug 41453] HTMLTreeBuilder needs an adoption agency : [Attachment 60468] Addressed Adam's feedback
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jul 4 13:29:54 PDT 2010
Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 41453: HTMLTreeBuilder needs an adoption agency
https://bugs.webkit.org/show_bug.cgi?id=41453
Attachment 60468: Addressed Adam's feedback
https://bugs.webkit.org/attachment.cgi?id=60468&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok. There's still work to do here around mutation events, etc, but we can do
that in a subsequent patch. Feel free to cq+ if you removed that
notImplemented() mentioned below on purpose.
WebCore/html/HTMLTreeBuilder.cpp:
+ notImplemented();
I thought there was a reason I had this notImplemented here.
WebCore/html/HTMLTreeBuilder.cpp:843
+ void HTMLTreeBuilder::reparentChildren(Element* oldParent, Element*
newParent)
I'm sad that this is still subject to mutation event tricks.
More information about the webkit-reviews
mailing list