[webkit-reviews] review denied: [Bug 41576] [chromium] Fix drawing of inset box shadows : [Attachment 60467] patch without junk

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Nico Weber <thakis at chromium.org>'s request for
review:
Bug 41576: [chromium] Fix drawing of inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=41576

Attachment 60467: patch without junk
https://bugs.webkit.org/attachment.cgi?id=60467&action=review

------- Additional Comments from mitz at webkit.org
A method called GraphicsContext::canvasClip() sounds like a bad idea. According
to GraphicsContext.h,

// This clip function is used only by <canvas> code

but this patch makes that comment false and illustrates why having this method
is a bad idea. Moreover, the change log (which mentions a bunch of files that
the patch doesn’t touch) does a very poor job of explaining the change.

I suggest eliminating canvasClip() and devising a better solution to the
platform-specific problem it was intended to solve; ideally, such a solution
will not require people writing cross-platform code to have to think about the
platform-specific problem. As things stand, there is no way for someone writing
rendering code to tell whether they should call clip() or canvasClip().