[webkit-reviews] review requested: [Bug 41403] InsertListCommand's modifyRange and doApply should be merged : [Attachment 60463] merges modifyRange and doApply and adds doApplyForSingleParagraph
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jul 3 18:06:09 PDT 2010
Ryosuke Niwa <rniwa at webkit.org> has asked for review:
Bug 41403: InsertListCommand's modifyRange and doApply should be merged
https://bugs.webkit.org/show_bug.cgi?id=41403
Attachment 60463: merges modifyRange and doApply and adds
doApplyForSingleParagraph
https://bugs.webkit.org/attachment.cgi?id=60463&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
I'm not happy about the fact doApplyForSingleParagraph relies on the selection
but just passing the starting/ending of paragraph breaks some tests because
moveParagraph makes some visible positions invalid by detaching it from the
document. So that should be done in a separate patch by replacing
moveParagraph by moveParagraphWithClones.
More information about the webkit-reviews
mailing list