[webkit-reviews] review granted: [Bug 41550] The missing plug-in indicator should be clickable : [Attachment 60446] patch v2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jon Honeycutt
<jhoneycutt at apple.com>'s request for review:
Bug 41550: The missing plug-in indicator should be clickable
https://bugs.webkit.org/show_bug.cgi?id=41550

Attachment 60446: patch v2
https://bugs.webkit.org/attachment.cgi?id=60446&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This doesn't seem to do any hit testing. So clicking anywhere in the plug-in,
even far away from the missing plug-in indicator, would trigger the function
call.

> +	   ChromeClient* client = page->chrome()->client();
> +	   client->missingPluginButtonClicked(this);
> +
> +	   return;

I'd write that more compactly like this:

    page->chrome()->client()->missingPluginButtonClicked(this);
    return;

Without the blank line or the local variable.

r=me