[webkit-reviews] review granted: [Bug 39625] [Qt] Sending a QInputMethodEvent::Selection event forces the Editor to go into Composition mode : [Attachment 57408] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 39625: [Qt] Sending a QInputMethodEvent::Selection event forces the Editor
to go into Composition mode
https://bugs.webkit.org/show_bug.cgi?id=39625

Attachment 57408: Patch
https://bugs.webkit.org/attachment.cgi?id=57408&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
Your current patch is an improvement on the current situation so r=me. If Simon
has more comments we can fix that in a follow up.

A bit of comments in the code would have been nice though

WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1479
 +	QCOMPARE(value, QString("Qit"));
Is this a right change? Seems like an error