[webkit-reviews] review canceled: [Bug 40607] Implement the sync DB API in workers : [Attachment 60412] patch #3: implementing DatabaseSync::transaction() and changeVersion() + tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 3 02:54:43 PDT 2010


Dumitru Daniliuc <dumi at chromium.org> has canceled Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 40607: Implement the sync DB API in workers
https://bugs.webkit.org/show_bug.cgi?id=40607

Attachment 60412: patch #3: implementing DatabaseSync::transaction() and
changeVersion() + tests
https://bugs.webkit.org/attachment.cgi?id=60412&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
Addressed the problems Michael and I talked about offline:
1. An attempt to run a transaction inside another transaction should
immediately result in an exception being thrown; added a test for that too.
2. Removed the SQLTransactionSyncClient class, and changed SQLTransactionClient
to be usable by both sync and async transactions.
3. Changed SQLStatementSync.cpp to be a 'svn copy' of SQLStatement.cpp.
4. Replaced 'typedef int ExceptionCode' with '#include "ExceptionCode.h"' in
all DB header files.
5. Changed the name of the SQLTransactionClient::didCommitTransaction() method
to didCommitWriteTransaction().

I also changed '#include <wtf/Threading.h>' to '#include
<wtf/ThreadSafeShared.h>' in a few callbacks, removed a few unnecessary
#includes in SQLTransactionClientChromium.cpp, and moved the code that runs a
transaction to a separate DatabaseSync::runTransaction() method, so it can be
shared by DatabaseSync::transaction() and DatabaseSync::changeVersion().


More information about the webkit-reviews mailing list