[webkit-reviews] review denied: [Bug 41384] Allow Chromium access to Select control choices : [Attachment 60150] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied George Yakovlev
<georgey at chromium.org>'s request for review:
Bug 41384: Allow Chromium access to Select control choices
https://bugs.webkit.org/show_bug.cgi?id=41384

Attachment 60150: Patch
https://bugs.webkit.org/attachment.cgi?id=60150&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/src/WebSelectElement.cpp:65
 +  
nit: only one new line

WebKit/chromium/src/WebSelectElement.cpp:60
 +		items[i] =
static_cast<HTMLOptionElement*>(sourceItems[i])->value();
instead of returning a list of the values of the items, how
about returning WebOptionElement objects instead?  otherwise,
i think the name of this method should be listItemValues to
better correspond to what it is returning.

WebOptionElement seems better to me.