[webkit-reviews] review granted: [Bug 41539] Move BOM handling out of the lexer and parser : [Attachment 60402] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted  review:
Bug 41539: Move BOM handling out of the lexer and parser
https://bugs.webkit.org/show_bug.cgi?id=41539

Attachment 60402: Patch
https://bugs.webkit.org/attachment.cgi?id=60402&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I think copyStringWithoutBOMs is unnecessarily inefficient in the case where it
finds a BOM.

I'd have the first loop remember the index of the BOM it found, and make that
the starting point of the second loop. I'd also remove the shrinkToFit call
(since it does an extra copy).