[webkit-reviews] review denied: [Bug 41527] Adding notification and touch events methods to WebChromeClient : [Attachment 60385] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 2 12:44:13 PDT 2010
Sam Weinig <sam at webkit.org> has denied Luiz Agostini
<luiz.agostini at openbossa.org>'s request for review:
Bug 41527: Adding notification and touch events methods to WebChromeClient
https://bugs.webkit.org/show_bug.cgi?id=41527
Attachment 60385: Patch
https://bugs.webkit.org/attachment.cgi?id=60385&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
> +
> +#if ENABLE(NOTIFICATIONS)
> + virtual WebCore::NotificationPresenter* notificationPresenter() const {
return 0; }
> +#endif
> +
> +#if ENABLE(TOUCH_EVENTS)
> + virtual void needTouchEvents(bool) { }
> +#endif
> +
Please put the implementation in the .cpp file.
r-.
More information about the webkit-reviews
mailing list