[webkit-reviews] review granted: [Bug 39532] REGRESSION: Enter does not trigger submit of forms when focus is on select. : [Attachment 60377] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 39532: REGRESSION: Enter does not trigger submit of forms when focus is on
select.
https://bugs.webkit.org/show_bug.cgi?id=39532

Attachment 60377: Patch
https://bugs.webkit.org/attachment.cgi?id=60377&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +		} else if (type == "selectBox") {
> +			control = document.createElement("select");
> +			control.size = 5;
> +			control.options.add(new Option("a"));

Not that I have anything against tabs in patches...

> +    } else if (event->type() == eventNames().keypressEvent) {

So, is it indeed keypress that triggers submission, not keydown?

r=me