[webkit-reviews] review denied: [Bug 40916] Web Inspector: In Styles pane jump from a CSS property name to the value by typing colon : [Attachment 60370] A little bit of refactoring

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Nikita Vasilyev <me at elv1s.ru>'s
request for review:
Bug 40916: Web Inspector: In Styles pane jump from a CSS property name to the
value by typing colon
https://bugs.webkit.org/show_bug.cgi?id=40916

Attachment 60370: A little bit of refactoring
https://bugs.webkit.org/attachment.cgi?id=60370&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Heh, now this breaks tabbing forward right after you've created a
new property. The tests I've been doing:

  - Double click and tab though everything
  - Tab to create a new property "color: red"
  - Tab to create a new property, tab off to cancel
  - Double click to edit the last property
  - Tab to create a new property, shift tab through the list (including the
selector)
  - Tab from a selector to the properties
  - Select all the text of a property, delete the text, then tab

The expected behavior for all of these should be clear. In fact, the last one
is broken in the nightlies right now.

I haven't looked too deeply at the actual code itself though. It looks good
at first glance!