[webkit-reviews] review requested: [Bug 40558] [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT : [Attachment 60363] patch - snapshot of current state (removed debugging code, fixed modes)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 2 06:36:29 PDT 2010
Roland Steiner <rolandsteiner at chromium.org> has asked for review:
Bug 40558: [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=40558
Attachment 60363: patch - snapshot of current state (removed debugging code,
fixed modes)
https://bugs.webkit.org/attachment.cgi?id=60363&action=review
------- Additional Comments from Roland Steiner <rolandsteiner at chromium.org>
Based on Kent-san's comment, uploaded a cleaned-up version of the current
state, without debugging message boxes, and with the filemodes corrected.
Apart from the code issues, as indicated with my first patch, please also check
whether my modifications to webkit.gyp are OK. I feel that having the include
dirs modification just for Windows is probably not correct.
More information about the webkit-reviews
mailing list