[webkit-reviews] review granted: [Bug 41250] Implement IDBObjectStore.get/set/remove : [Attachment 60208] Patch

[bugzilla-daemon at webkit.org]

Dumitru Daniliuc <dumi at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 41250: Implement IDBObjectStore.get/set/remove
https://bugs.webkit.org/show_bug.cgi?id=41250

Attachment 60208: Patch
https://bugs.webkit.org/attachment.cgi?id=60208&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
r=me, with a few minor comments. please keep an eye on the bots after landing
this patch.

WebCore/storage/IDBObjectStoreRequest.idl:37
 +	    [CallWith=ScriptExecutionContext] IDBRequest put(in
SerializedScriptValue value, in [Optional] IDBKey key);
are you missing the declaration for remove()?

WebKit/chromium/public/WebIDBKey.h:45
 +	WebIDBKey(int32_t number) { assign(number); }
int32_t --> unsigned long ?

WebKit/chromium/src/WebIDBKey.cpp:31
 +  #include "IDBKey.h"
move inside ENABLE(INDEXED_DB)