[webkit-reviews] review denied: [Bug 40916] Web Inspector: In Styles pane jump from a CSS property name to the value by typing colon : [Attachment 59250] Typing colon jumps from a CSS property name to the value

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 2 01:44:53 PDT 2010


Joseph Pecoraro <joepeck at webkit.org> has denied Nikita Vasilyev <me at elv1s.ru>'s
request for review:
Bug 40916: Web Inspector: In Styles pane jump from a CSS property name to the
value by typing colon
https://bugs.webkit.org/show_bug.cgi?id=40916

Attachment 59250: Typing colon jumps from a CSS property name to the value
https://bugs.webkit.org/attachment.cgi?id=59250&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Looks good, feels pretty good as well!

Even with your adjustment to the blankInput regex, this still breaks
⇧⇥ (navigate backwards) from a new property. r- because of this.
I didn't investigate why.

Also, this really makes me want to use tab to go from the property
to the value. I'd strongly suggest overriding tab in this case to
do what you do for ":" when the caret is in the property.


More information about the webkit-reviews mailing list