[webkit-reviews] review denied: [Bug 40886] Web Inspector: Backend Should Provide Full Supported CSS Properties List : [Attachment 60304] [PATCH] Addressed Style Issue and Rebased

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 40886: Web Inspector: Backend Should Provide Full Supported CSS Properties
List
https://bugs.webkit.org/show_bug.cgi?id=40886

Attachment 60304: [PATCH] Addressed Style Issue and Rebased
https://bugs.webkit.org/attachment.cgi?id=60304&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/InspectorFrontendHost.cpp:35
 +  #include "CSSPropertyNames.h"
This should not be defined in a front-end host. Imagine the remote debugging
scenario. Frontend host is a simple stub there. What you really need is to
fetch the actual list of properties from the inspected side.

WebCore/inspector/InspectorFrontendHost.cpp:206
 +  ScriptArray InspectorFrontendHost::supportedCSSProperties()
ScriptArray will soon go away. But you can still use it in InspectorController
- we will migrate everything alltogether. However, using debuggerWorld her is a
hack - if you implement it properly on the inspected page side, you will not
have such a problem - there is a factory for ScriptArrays.

WebCore/inspector/front-end/CSSCompletions.js:3
 +  WebInspector.CSSCompletions.startsWith = function(prefix)
Nit: When did we get this file... I think we should merge it with
CSSStyleModel!

WebCore/inspector/front-end/SourceCSSTokenizer.js: 
 +	this._propertyKeywords = [
Nice!