[webkit-reviews] review granted: [Bug 41503] Implement processFakePEndTagIfPInScope : [Attachment 60335] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 41503: Implement processFakePEndTagIfPInScope
https://bugs.webkit.org/show_bug.cgi?id=41503

Attachment 60335: Patch
https://bugs.webkit.org/attachment.cgi?id=60335&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/html/HTMLTreeBuilder.cpp:313
 +	if (!m_openElements.inScope(pTag.localName()))
This is sad.  We'll add a QualifiedName version.

WebCore/html/HTMLTreeBuilder.cpp:315
 +	AtomicHTMLToken endP(HTMLToken::EndTag, pTag.localName());
We need an function to handle this token creation for us.  I think
AtomicHTMLTokens should be copyable and that would simplify a lot of this code.