[webkit-reviews] review granted: [Bug 40835] Adds support for throwing behavior of SerializedScriptValue to be specified in the IDL. : [Attachment 60241] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 2 00:33:12 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has granted Marcus Bulach
<bulach at chromium.org>'s request for review:
Bug 40835: Adds support for throwing behavior of SerializedScriptValue to be
specified in the IDL.
https://bugs.webkit.org/show_bug.cgi?id=40835

Attachment 60241: Patch
https://bugs.webkit.org/attachment.cgi?id=60241&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebCore/bindings/scripts/test/JS/JSTestObj.cpp:833
 +	JSC::JSValue result =  ec ? jsUndefined() :  serializedScriptValue ?
serializedScriptValue->deserialized() : jsNull();
Personally, I think this is cleaner:

if (ec) {
    setDOMException
    return jsUndefined;
}
return serializedScriptVlaue->deserilized()

WebCore/bindings/scripts/CodeGeneratorJS.pm:2475
 +	$ret = $ret . " serializedScriptValue ?
serializedScriptValue->deserialized() : jsNull();\n";
you get double spaces between a few items here...not that big of a deal tho



r=me


More information about the webkit-reviews mailing list