[webkit-reviews] review denied: [Bug 40884] [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles : [Attachment 59197] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <andreas.kling at nokia.com> has denied Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 40884: [Qt] When we render WebGL offscreen, color conversion cost a lot of
CPU cycles
https://bugs.webkit.org/show_bug.cgi?id=40884

Attachment 59197: Patch
https://bugs.webkit.org/attachment.cgi?id=59197&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:299
 +  
Unnecessary empty line.

WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:579
 +	// GL give us ABGR on 32 bits, and with the origin at the bottom left
s/give/gives/

WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:465
 +	free(m_pixels);
WebKit normally uses new/delete, is there a specific reason for malloc/free
here?

WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:540
 +  static inline quint32 swapPixelsRGB32(quint32 pixel)
I don't like this function name - it's swapping color values, not pixels.

WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:586
 +	    format = QImage::Format_ARGB32_Premultiplied;
 +	    format = QImage::Format_RGB32;
You're setting format twice here. It ends up being RGB32 which is incorrect for
this code path.

Looks good otherwise, r- for the wrong format in the alpha channel case.