[webkit-reviews] review denied: [Bug 41476] Dragging URL with linebreak truncates URL : [Attachment 60292] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 1 15:37:47 PDT 2010
Daniel Cheng <dcheng at chromium.org> has denied Daniel Cheng
<dcheng at chromium.org>'s request for review:
Bug 41476: Dragging URL with linebreak truncates URL
https://bugs.webkit.org/show_bug.cgi?id=41476
Attachment 60292: Patch
https://bugs.webkit.org/attachment.cgi?id=60292&action=review
------- Additional Comments from Daniel Cheng <dcheng at chromium.org>
(In reply to comment #2)
> (From update of attachment 60292 [details])
> This patch makes zero sense to me. The source is clearly broken.
See comment #4 on http://code.google.com/p/support/issues/detail?id=2363. If
you select the entire URL, including the section that was badly wrapped, then
you get two different behaviors depending on how you start the drag:
1) If you start the drag by clicking on the link and drop it in a WebKit view
to navigate, you will navigate to a broken URL.
2) If you start the drag by clicking on the non-linked portion of the URL, you
will navigate to the complete URL.
Obviously the link itself is broken, but it seems strange to have two different
behaviors for dragging around the same bit of data.
I'll be moving the ClipboardChromium change into a separate patch.
More information about the webkit-reviews
mailing list