[webkit-reviews] review granted: [Bug 41489] Make process launching asynchronous : [Attachment 60294] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 41489: Make process launching asynchronous
https://bugs.webkit.org/show_bug.cgi?id=41489

Attachment 60294: Patch
https://bugs.webkit.org/attachment.cgi?id=60294&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> +    // Register ourselves.
> +    kern_return_t kr = bootstrap_register2(bootstrap_port,
(char*)"com.apple.WebKit.WebProcess", listeningPort, /*
BOOTSTRAP_PER_PID_SERVICE */ 1);
> +    if (kr)
> +	   NSLog(@"bootstrap_register2 result: %x", kr);
> +    
> +    pid_t processIdentifier;
> +    int result = posix_spawn(&processIdentifier, path, 0, 0, (char
*const*)args, *_NSGetEnviron());
> +    if (result)
> +	   NSLog(@"posix_spawn result: %d", result);

Not a new issue but, should we bail on errors here?

r=me.