[webkit-reviews] review requested: [Bug 40793] [GTK] The size of the shadow image uses the standard deviation size instead of the blur radius : [Attachment 60279] Proposed patch

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has asked  for review:
Bug 40793: [GTK] The size of the shadow image uses the standard deviation size
instead of the blur radius
https://bugs.webkit.org/show_bug.cgi?id=40793

Attachment 60279: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=60279&action=review

------- Additional Comments from Alejandro G. Castro <alex at igalia.com>
This is a first final proposal, I checked the visual result of other browsers.


	    The kernelSize variable was renamed to radius and recalculated
	    considering the CSS3 specification
	    http://www.w3.org/TR/css3-background/#the-box-shadow, and the
	    visual result of other browsers. The HTML5 canvas shadow standard
	    deviation calculation that was used, was not appropiate for the
	    blur distance specified in the CSS3.

	    Added also the recomendations of SVG regarding the kernel size
	    calculation for the approximation of the gaussian
	    blur. http://www.w3.org/TR/SVG/filters.html#feGaussianBlurElement