[webkit-reviews] review granted: [Bug 41190] Canvas: Don't paint with empty radial gradients : [Attachment 60275] Proposed patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 1 12:58:02 PDT 2010
Darin Adler <darin at apple.com> has granted Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 41190: Canvas: Don't paint with empty radial gradients
https://bugs.webkit.org/show_bug.cgi?id=41190
Attachment 60275: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=60275&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> - bool isZeroSize() const { return m_p0.x() == m_p1.x() && m_p0.y() ==
m_p1.y(); }
> + bool isZeroSize() const { return m_p0.x() == m_p1.x() && m_p0.y() ==
m_p1.y() && (m_radial ? m_r0 == m_r1 : true); }
I think it would read better as:
(!m_radial || m_r0 == m_r1)
More information about the webkit-reviews
mailing list