[webkit-reviews] review denied: [Bug 39843] [GTK] WebKitWebView should support drops : [Attachment 58916] Updated patch for this issue

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 39843: [GTK] WebKitWebView should support drops
https://bugs.webkit.org/show_bug.cgi?id=39843

Attachment 58916: Updated patch for this issue
https://bugs.webkit.org/attachment.cgi?id=58916&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
WebCore/platform/gtk/ClipboardUtilitiesGtk.cpp:42
 +  GdkDragAction dragOperationToGdkDragAction(DragOperation coreAction)
I feel this name is way too similar to the other function. How about
dragOperationToSingleGdkDragAction?

WebCore/platform/gtk/ClipboardUtilitiesGtk.cpp:58
 +	// to use it all applicable flags are on.
I failed to parse this comment. s/use it/check/?

WebKit/gtk/webkit/webkitwebview.cpp:1385
 +	g_idle_add(reinterpret_cast<GSourceFunc>(doDragLeaveLater),
priv->droppingContexts->get(context));
I learned to not trust idles. They get starved, and we lose. Can we replace
this with a g_timeout_add(0...) call instead? If not, I'd prefer to have a flag
that you raise to say these actions are pending, and perform them after
handling drag-drop (perhaps register the timeout at that point?).

r- for the above, but otherwise yay!