[webkit-reviews] review granted: [Bug 41084] Get accelerated compositing working with webkit2 : [Attachment 60268] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 1 12:10:09 PDT 2010


Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 41084: Get accelerated compositing working with webkit2
https://bugs.webkit.org/show_bug.cgi?id=41084

Attachment 60268: Patch
https://bugs.webkit.org/attachment.cgi?id=60268&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I’m not a huge fan of xxxRecursive as the name for the version that includes
sublayers. The "recursive" suffix seems a little vague and I don’t like it in
places we already have it.

If the normal case would be to sync the sublayers, then I'd suggest calling the
single-layer version syncCompositingStateForThisLayerOnly or something like
that. Or you could call the new one syncCompositingStateIncludingSublayers.


More information about the webkit-reviews mailing list