[webkit-reviews] review denied: [Bug 40807] [EFL] add support for logging : [Attachment 59457] The comment was fixed

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Joone Hur <joone at kldp.org>'s
request for review:
Bug 40807: [EFL] add support for logging
https://bugs.webkit.org/show_bug.cgi?id=40807

Attachment 59457: The comment was fixed
https://bugs.webkit.org/attachment.cgi?id=59457&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
WebCore/platform/efl/LoggingEfl.cpp:48
 +	char* logv = strtok(logEnv, " ");
This is wrong. strtok modifies the string it is given, while getenv returns a
pointer to a string that is part of the actual environment, so modifying it
modifies the environment. Isn't the EFL port using glib for some other stuff
already? Why not share the same implementation with GTK+, since for now you're
going with the same approach?

r- for the reason above; in a later patch you may want to set the commit-queue
flag to ?, to indicate you wish it to be automatically committed, unless you
want one of the committers to do it manually =)