[webkit-reviews] review granted: [Bug 40271] The HTML5 canvas 2d.drawImage.zerocanvas test does not pass : [Attachment 60249] Proposed patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 1 11:29:08 PDT 2010


Darin Adler <darin at apple.com> has granted Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 40271: The HTML5 canvas 2d.drawImage.zerocanvas test does not pass
https://bugs.webkit.org/show_bug.cgi?id=40271

Attachment 60249: Proposed patch v3
https://bugs.webkit.org/attachment.cgi?id=60249&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (!srcCanvasRect.width() || !srcCanvasRect.height()) {

Could you use srcCanvasRect.isEmpty() instead? If so, I think it would read
nicer.


More information about the webkit-reviews mailing list