[webkit-reviews] review granted: [Bug 5861] feConvolveMatrix filter is not implemented : [Attachment 60210] updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 1 02:09:21 PDT 2010
Nikolas Zimmermann <zimmermann at kde.org> has granted Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 5861: feConvolveMatrix filter is not implemented
https://bugs.webkit.org/show_bug.cgi?id=5861
Attachment 60210: updated patch
https://bugs.webkit.org/attachment.cgi?id=60210&action=review
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Great patch, thanks so much!
r=me.WebCore/svg/graphics/filters/SVGFEConvolveMatrix.h:92
+ // Only once usage -> can be ALWAYS_INLINE
Just remove this comment, I don't think it helps much.
WebCore/svg/graphics/filters/SVGFEConvolveMatrix.h:96
+ // Only once usage -> can be ALWAYS_INLINE
Ditto.
More information about the webkit-reviews
mailing list