[webkit-reviews] review granted: [Bug 36564] Performance regression for setting content of <text> in SVG : [Attachment 60211] Initial patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 1 01:24:16 PDT 2010
Eric Seidel <eric at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 36564: Performance regression for setting content of <text> in SVG
https://bugs.webkit.org/show_bug.cgi?id=36564
Attachment 60211: Initial patch
https://bugs.webkit.org/attachment.cgi?id=60211&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/rendering/SVGRenderSupport.cpp:107
+ repaintRect = object->repaintRectInLocalCoordinates();
Should this ASSERT that the repaintRect has not been computed?
ASSERT(repaintRect == FloatRect())? or whatever the ASSERT would be.
Otherwise this looks fine. Please fix the bogus inlining.
More information about the webkit-reviews
mailing list