[webkit-reviews] review requested: [Bug 41447] [GTK] Extra nullcheck needed at SelectionControllerGtk.cpp : [Attachment 60213] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 41447: [GTK] Extra nullcheck needed at SelectionControllerGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=41447

Attachment 60213: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=60213&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #2)
> (From update of attachment 60209 [details])
> I think doing:
> 
> if (!accessibilityObject)
>     return;
> 
> is much better.

Done.

> Also, we should look into why a NULL object is being created in the first
place...

Agree, and I have the feeling is related to the rendering object not being
created by that time, although that would be quite weir and would be indeed
another bug for sure... In any case I think this null check doesn't hurt
either.