[webkit-reviews] review denied: [Bug 41447] [GTK] Extra nullcheck needed at SelectionControllerGtk.cpp : [Attachment 60209] Patch proposal
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 1 01:06:48 PDT 2010
Xan Lopez <xan.lopez at gmail.com> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 41447: [GTK] Extra nullcheck needed at SelectionControllerGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=41447
Attachment 60209: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=60209&action=review
------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
I think doing:
if (!accessibilityObject)
return;
is much better.
Also, we should look into why a NULL object is being created in the first
place...
More information about the webkit-reviews
mailing list