[webkit-reviews] review granted: [Bug 33953] [Android] Android lacks V8 equivalent of JavaStringJSC.h : [Attachment 47698] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 31 15:57:06 PST 2010
Ariya Hidayat <ariya.hidayat at gmail.com> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 33953: [Android] Android lacks V8 equivalent of JavaStringJSC.h
https://bugs.webkit.org/show_bug.cgi?id=33953
Attachment 47698: Patch
https://bugs.webkit.org/attachment.cgi?id=47698&action=review
------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
> + const char* cs = getCharactersFromJStringInEnv(e, s);
> + {
> + m_utf8String = WebCore::CString(cs, size);
> + }
Minor nitpick: since we don't need JSLock here, do we need to put that line in
its own block?
Otherwise, LGTM.
More information about the webkit-reviews
mailing list