[webkit-reviews] review denied: [Bug 34376] [Qt] Use Windows style on Maemo 5 : [Attachment 47769] Patch

[bugzilla-daemon at webkit.org]

Ariya Hidayat <ariya.hidayat at gmail.com> has denied Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 34376: [Qt] Use Windows style on Maemo 5
https://bugs.webkit.org/show_bug.cgi?id=34376

Attachment 47769: Patch
https://bugs.webkit.org/attachment.cgi?id=47769&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
> +	   [Qt] Use Windows style on Maemo 5

Better to refer it as "Use the fallback style...". Note that the fallback style
could be the application style if the Windows style can't be created (e.g. the
style plugin for that is missing or not available).

>  void RenderThemeQt::setPaletteFromPageClientIfExists(QPalette& palette)
const
>  {
> +#ifdef Q_WS_MAEMO_5
> +    static QPalette lightGrayPalette(Qt::lightGray);
> +    palette = lightGrayPalette;
> +#else
>      // If the webview has a custom palette, use it
>      if (!m_page)
>	   return;
> @@ -786,6 +795,7 @@ void
RenderThemeQt::setPaletteFromPageClientIfExists(QPalette& palette) const
>      if (!pageClient)
>	   return;
>      palette = pageClient->palette();
> +#endif

Why don't we have a quick return like in qStyle() patch above? That way, the
alternative code path is easier to spot.

r- for these minor issues, otherwise LGTM.