[webkit-reviews] review granted: [Bug 34400] Web Inspector: Fix rest of the NativeTextViewer (line numbers, conditional breakpoints, selection). : [Attachment 47799] [PATCH] Proposed change.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 31 14:00:23 PST 2010


Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 34400: Web Inspector: Fix rest of the NativeTextViewer (line numbers,
conditional breakpoints, selection).
https://bugs.webkit.org/show_bug.cgi?id=34400

Attachment 47799: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=47799&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	       return nextElement.offsetTop - element.offsetTop;
> +	   } else
> +	       return element.parentElement.offsetHeight - element.offsetTop;

NO need for the "} else" after a return.


More information about the webkit-reviews mailing list