[webkit-reviews] review granted: [Bug 34391] Web Inspector: Introduce DivBasedTextViewer. : [Attachment 47790] [PATCH] Same with less typos.

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 34391: Web Inspector: Introduce DivBasedTextViewer.
https://bugs.webkit.org/show_bug.cgi?id=34391

Attachment 47790: [PATCH] Same with less typos.
https://bugs.webkit.org/attachment.cgi?id=47790&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +WebInspector.DivBasedTextViewer = function(textModel, platform)
> +{
> +    WebInspector.TextEditor.call(this, textModel, platform);

I'm not fond of "DivBasedTextViewer" as a class name. What about
"NativeTextViewer", "SimpleTextViewer" or "ClassicTextViewer"? Or, not great
but, "DOMBasedTextViewer".

> +    useCanvasBasedEditor: true

Should be false?