[webkit-reviews] review denied: [Bug 34332] Web Inspector: Lazy-load resource contents in the Resources panel : [Attachment 47720] [PATCH] Proposed solution
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 31 04:41:38 PST 2010
Pavel Feldman <pfeldman at chromium.org> has denied review:
Bug 34332: Web Inspector: Lazy-load resource contents in the Resources panel
https://bugs.webkit.org/show_bug.cgi?id=34332
Attachment 47720: [PATCH] Proposed solution
https://bugs.webkit.org/attachment.cgi?id=47720&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
It is not clear to me why these changes are necessary. Why not to simply remove
setupSourceFrameIfNeeded from the SourceView::show and call it as an abstract
function from within ResourceView upon tab switch?
Patch also seems to be wrong in a way that it does not load resource if lazy
load is set to 'false'.
More information about the webkit-reviews
mailing list