[webkit-reviews] review requested: [Bug 34317] [GStreamer] Add a WebKit HTTP/HTTPS source that uses WebKit's network infrastructure : [Attachment 47764] 0001-Add-webkitwebsrc-a-GStreamer-HTTP-HTTPS-source-using.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 30 03:03:51 PST 2010


Sebastian Dröge <slomo at circular-chaos.org> has asked  for review:
Bug 34317: [GStreamer] Add a WebKit HTTP/HTTPS source that uses WebKit's
network infrastructure
https://bugs.webkit.org/show_bug.cgi?id=34317

Attachment 47764:
0001-Add-webkitwebsrc-a-GStreamer-HTTP-HTTPS-source-using.patch
https://bugs.webkit.org/attachment.cgi?id=47764&action=review

------- Additional Comments from Sebastian Dröge <slomo at circular-chaos.org>
Lots of style fixes... for the remaining ones, I don't think they should be
fixed. Using camel case function names is not really GLib'ish and using 0
instead of NULL in varargs functions is not a good idea either (on x86-64 0
would be passed as 32 bit value while the function itself wants a 64 bit
value).


More information about the webkit-reviews mailing list